Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent TLEs from referencing other TLEs in requires #131

Closed
olirice opened this issue Oct 28, 2023 · 1 comment · Fixed by #143
Closed

Prevent TLEs from referencing other TLEs in requires #131

olirice opened this issue Oct 28, 2023 · 1 comment · Fixed by #143
Labels
enhancement New feature or request

Comments

@olirice
Copy link
Contributor

olirice commented Oct 28, 2023

Description

We don't currently have dependency resolution in dbdev.

Currently, authors might specify requires in their control file to depend on other dbdev TLEs expecting that to work. It would be nice if we could detect and reject those projects on upload with a useful error message.

In the future, if we implement dependency resolutions, we can loosen that restriction.

Note: we still want to allow authors to define dependencies against native extensions (pgvector, hypopg, etc)

@olirice olirice added the enhancement New feature or request label Oct 28, 2023
@olirice
Copy link
Contributor Author

olirice commented Nov 9, 2023

How will we detect TLEs vs non-TLEs

Since its an temporary measure until we get dependency resolution, how about creating an dependency allow list in the app schema and approve pre-installed extensions on any of the big providers Supabase/AWS/Azure/Google/Digital Ocean. Users can open issues if we miss anything.

We can reference that allow list when authors upload extensions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant