fix: Emit password recovery event from verifyOtp when otp type is recovery #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kangmingtay
approved these changes
Dec 29, 2023
|
🎉 This PR is included in version 2.62.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Currently when the user goes through the password recovery flow via OTP and calls the
verifyOtp()method, theSIGNED_INauth event is emitted instead ofPASSWORD_RECOVERYevent.What is the new behavior?
When the user goes through the password recovery flow using email OTP, the
PASSWORD_RECOVERYevent is emitted.Additional context
A Flutter SDK user reported this, and thought it probably makes sense to bring it to the JS client as well. supabase/supabase-flutter#774