Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary events and multi-tab #366

Merged
merged 4 commits into from
Aug 4, 2022

Conversation

kangmingtay
Copy link
Member

What kind of change does this PR introduce?

  • Remove unnecessary events emitted
  • Remove multi-tab stuff because getSession() will always ensure that a valid session is returned or no session at all

Copy link
Member

@alaister alaister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kangmingtay kangmingtay merged commit 88b1027 into next Aug 4, 2022
@kangmingtay kangmingtay deleted the km/refactor-notify-events branch August 4, 2022 10:39
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

🎉 This PR is included in version 1.23.0-next.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.0.0-rc.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants