fix: add index on (session_id, revoked) in refresh_tokens (#765)

supabase · Oct 21, 2022 · 5ba3aca · 5ba3aca
1 parent 3332072
commit 5ba3aca
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/migrations/20221021073300_add_refresh_tokens_session_id_revoked_index.up.sql b/migrations/20221021073300_add_refresh_tokens_session_id_revoked_index.up.sql
@@ -0,0 +1 @@
+create index if not exists refresh_tokens_session_id_revoked_idx on {{ index .Options "Namespace" }}.refresh_tokens (session_id, revoked);
diff --git a/models/refresh_token.go b/models/refresh_token.go
@@ -72,7 +72,7 @@ func RevokeTokenFamily(tx *storage.Connection, token *RefreshToken) error {
 	var err error
 	tablename := (&pop.Model{Value: RefreshToken{}}).TableName()
 	if token.SessionId != nil {
-		err = tx.RawQuery(`update `+tablename+` set revoked = true where session_id = ?;`, token.SessionId).Exec()
+		err = tx.RawQuery(`update `+tablename+` set revoked = true where session_id = ? and revoked = false;`, token.SessionId).Exec()
 	} else {
 		err = tx.RawQuery(`
 		with recursive token_family as (