fix: improve MFA QR Code resilience so as to support providers like 1Password #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf
reviewed
Feb 26, 2024
hf
approved these changes
Feb 26, 2024
J0
added a commit
that referenced
this pull request
Feb 27, 2024
…Password (#1455) ## What kind of change does this PR introduce? Reduced version of #1438. This increases the [error correction level](https://pkg.go.dev/github.com/boombuler/barcode@v1.0.1/qr#ErrorCorrectionLevel) which should make the QR Code easier to scan Other aspects such as visibility of QR code and potentially size adjustments will be handled for later. Want to get the minimal possible change out that might fix the issue Works with 1Password locally, will test against Supabase setup once merged
J0
added a commit
that referenced
this pull request
Mar 1, 2024
…Password (#1455) ## What kind of change does this PR introduce? Reduced version of #1438. This increases the [error correction level](https://pkg.go.dev/github.com/boombuler/barcode@v1.0.1/qr#ErrorCorrectionLevel) which should make the QR Code easier to scan Other aspects such as visibility of QR code and potentially size adjustments will be handled for later. Want to get the minimal possible change out that might fix the issue Works with 1Password locally, will test against Supabase setup once merged
hf
pushed a commit
that referenced
this pull request
Mar 5, 2024
🤖 I have created a release *beep* *boop* --- ## [2.144.0](v2.143.0...v2.144.0) (2024-03-04) ### Features * add configuration for custom sms sender hook ([#1428](#1428)) ([1ea56b6](1ea56b6)) * anonymous sign-ins ([#1460](#1460)) ([130df16](130df16)) * clean up test setup in MFA tests ([#1452](#1452)) ([7185af8](7185af8)) * pass transaction to `invokeHook`, fixing pool exhaustion ([#1465](#1465)) ([b536d36](b536d36)) * refactor resource owner password grant ([#1443](#1443)) ([e63ad6f](e63ad6f)) * use dummy instance id to improve performance on refresh token queries ([#1454](#1454)) ([656474e](656474e)) ### Bug Fixes * expose `provider` under `amr` in access token ([#1456](#1456)) ([e9f38e7](e9f38e7)) * improve MFA QR Code resilience so as to support providers like 1Password ([#1455](#1455)) ([6522780](6522780)) * refactor request params to use generics ([#1464](#1464)) ([e1cdf5c](e1cdf5c)) * revert refactor resource owner password grant ([#1466](#1466)) ([fa21244](fa21244)) * update file name so migration to Drop IP Address is applied ([#1447](#1447)) ([f29e89d](f29e89d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Reduced version of #1438. This increases the error correction level which should make the QR Code easier to scan
Other aspects such as visibility of QR code and potentially size adjustments will be handled for later. Want to get the minimal possible change out that might fix the issue
Works with 1Password locally, will test against Supabase setup once merged