Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify endpoint improve error responses #25

Closed
awalias opened this issue Nov 2, 2020 · 2 comments
Closed

verify endpoint improve error responses #25

awalias opened this issue Nov 2, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@awalias
Copy link
Member

awalias commented Nov 2, 2020

verify token endpoint currently returns User not found if the token has expired, should instead return token expired error

or if not going to be called via API, then can also redirect to something like <SITE_URL>#error_description=token_expired

@awalias awalias added the enhancement New feature or request label Nov 2, 2020
@icecream78
Copy link
Contributor

Hi.
I looked through the source code of verify function and havent found any checks for confirmed token expiration. Do you need this type of check? Only thing that Ive found, when no confirmation_token found in db and returned "User not found" error.
English is not my native language, so if it something was written not correct don`t blame me=)

@awalias
Copy link
Member Author

awalias commented Nov 4, 2020

you're correct @icecream78 , the only way to expire a confirmation token right now is to replace it with a more recent one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants