feat: replace current QR Code generation libraries #1438
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0
force-pushed
the
j0/replace_existing_qr_code_library
branch
from
e6dccfe
to
4f6e477
Compare
J0
changed the title
J0
added a commit
that referenced
this pull request
Feb 26, 2024
…Password (#1455) ## What kind of change does this PR introduce? Reduced version of #1438. This increases the [error correction level](https://pkg.go.dev/github.com/boombuler/barcode@v1.0.1/qr#ErrorCorrectionLevel) which should make the QR Code easier to scan Other aspects such as visibility of QR code and potentially size adjustments will be handled for later. Want to get the minimal possible change out that might fix the issue Works with 1Password locally, will test against Supabase setup once merged
J0
added a commit
that referenced
this pull request
Feb 27, 2024
…Password (#1455) ## What kind of change does this PR introduce? Reduced version of #1438. This increases the [error correction level](https://pkg.go.dev/github.com/boombuler/barcode@v1.0.1/qr#ErrorCorrectionLevel) which should make the QR Code easier to scan Other aspects such as visibility of QR code and potentially size adjustments will be handled for later. Want to get the minimal possible change out that might fix the issue Works with 1Password locally, will test against Supabase setup once merged
J0
added a commit
that referenced
this pull request
Mar 1, 2024
…Password (#1455) ## What kind of change does this PR introduce? Reduced version of #1438. This increases the [error correction level](https://pkg.go.dev/github.com/boombuler/barcode@v1.0.1/qr#ErrorCorrectionLevel) which should make the QR Code easier to scan Other aspects such as visibility of QR code and potentially size adjustments will be handled for later. Want to get the minimal possible change out that might fix the issue Works with 1Password locally, will test against Supabase setup once merged
|
Closing this PR, since it was split into two issues:
We still hope to remove the QR Code dependency at a slightly later date |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Currently, the generated QR Code can't be detected by providers such as 1Password on certain occasions.
Additionally, it uses an external library when there really isn't a need for one.
We use our own QR Code generation and use
barcodeinstead of a wrapper libraryWe need to check a few invariants hold before proceeding:
Of course, we should also check that it works with 1Password