Skip to content
This repository has been archived by the owner on May 13, 2023. It is now read-only.

Chore: complete test coverage #1

Closed
phamhieu opened this issue Oct 27, 2020 · 8 comments
Closed

Chore: complete test coverage #1

phamhieu opened this issue Oct 27, 2020 · 8 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@phamhieu
Copy link
Member

Chore

Describe the chore

We need help with completing test coverage for this library. We need to have all test cases as original realtime-js. There are 2 test files:

  • channel_test.dart
  • socket_test.dart

Additional context

This lib is based on web_socket_channel to create WebSocket connections. We only use IOWebSocketChannel which wraps dart:io's WebSocket class

@phamhieu phamhieu added the good first issue Good for newcomers label Oct 27, 2020
@gozeloglu
Copy link

Hi @phamhieu I am newbie in open source. I want to help you. I can take this issue on me. But I will may need your help as a senior developer 😄 .

@phamhieu phamhieu assigned phamhieu and gozeloglu and unassigned phamhieu Nov 3, 2020
@phamhieu
Copy link
Member Author

phamhieu commented Nov 3, 2020

Hey @gozeloglu thanks for your interest in this project. Feel free to let me know if you need help.

@gozeloglu
Copy link

Thank you @phamhieu :) I have couple of questions. I used Dart for Flutter. I know Dart from Flutter. And I used Android Studio while developing Flutter apps. But I am not sure that can I use Android Studio for this project. Can I use Android Studio? Or should I use different IDE? The other question is that I will convert the JS test to Dart test, right? I want to be sure the issue. By the way, I am a little bit bussy nowadays. That's why I will send small PRs to you when I complete the one test immediately. I want to let you know. Thanks in advance.

@phamhieu
Copy link
Member Author

phamhieu commented Nov 3, 2020

Can I use Android Studio? Or should I use different IDE?

Yes, you can use Android Studio to develop Dart package. More info here https://dart.dev/tools/jetbrains-plugin

The other question is that I will convert the JS test to Dart test, right?

Yes, we want a complete test coverage like realtime-js.
You will need to use HttpServer to create a mock server. There are examples from web_socket_channel test
If you are stuck at any test-case, just let me know.

That's why I will send small PRs to you when I complete the one test immediately

Noted. No worry.

@gozeloglu
Copy link

Thank you! I will start as soon as possible.

@hardiksachan
Copy link
Contributor

Hey @phamhieu I want to contribute. I can write the tests. I'll send you PRs as soon as I finish a test or a test group.

@phamhieu
Copy link
Member Author

phamhieu commented Nov 14, 2020

Thanks you, @hardiksachan for contributing to this project. Love your work on the PR.

@hardiksachan
Copy link
Contributor

Happy to help! I have sent one more PR, please review it.

@phamhieu phamhieu closed this as completed Feb 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants