This repository has been archived by the owner on May 13, 2023. It is now read-only.
fix: don't apply toString() to json #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Should I fix the relative imports too? I think the dynamic linter fails are hard to fix. |
|
@Vinzent03 they're not your fault tho |
|
Yeah I know, but I can add this if you want to. |
|
@Vinzent03 it'd be awesome! |
|
@bdlukaa Should I ignore the dynamic rule https://dart-lang.github.io/linter/lints/avoid_dynamic_calls.html in |
|
Any updates? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, each column value is turned to
Stringvia.toString(), but when this gets applied to aMap/jsonthe corresponding string isn't a valid string presentation of the map. So decoding it again withjson.decode()fails. I removed the.toString()call, because it's either a Map or a String. If it's a bool, it gets recognized as such either way later on intoBooleancalled inconvertCell()I see it got already discussed in #30