chore: Added 9 tests to socket_test.dart

[hardiksachan]

What kind of change does this PR introduce?

Adds test to socket_test.dart

Tests added:

• disconnect

  • calls connection close callback
  • does not throw when no connection

• channel

  • returns channel with given topic and params
  • adds channel to sockets channels list

• remove

  • removes given channel from channels

• push

  • sends data to connection when connected
  • buffers data when not connected

• makeRef

  • returns next message ref
  • restarts for overflow

[hardiksachan]

EDIT 1: Added 2 more tests

Adds test to socket_test.dart

Tests added:

• sendHeartbeat
  • pushes heartbeat data when connected
  • no ops when not connected

[phamhieu]

@hardiksachan nice work!! Thanks you

There's a failed test. Can you help check.

[hardiksachan]

You will need to update makeRef(). Something like this

String makeRef() {
    const int int64MaxValue = 9223372036854775807;
    int newRef;
    if (ref == int64MaxValue) {
      newRef = 0;
    } else {
      newRef = ref + 1;
    }
    ref = newRef;

    return ref.toString();
  }

[phamhieu]

You will need to update makeRef(). Something like this

String makeRef() {
    const int int64MaxValue = 9223372036854775807;
    int newRef;
    if (ref == int64MaxValue) {
      newRef = 0;
    } else {
      newRef = ref + 1;
    }
    ref = newRef;

    return ref.toString();
  }

can you remove this test from this PR. Then create another PR with main code update for makeRef and the test-case.

[hardiksachan]

Yeah! Sure.

[hardiksachan]

Hey, can you look at the failed test case. I have no idea why it is failing.