feat: add search param to list function #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inian
approved these changes
Mar 26, 2022
|
@alaister could you update https://supabase.com/docs/reference/javascript/storage-from-list as well please? |
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@thebengeu Sure! We'll need to get supabase/storage#127 merged in too for it to work correctly. I think Joshen said it was all working with the frontend, but maybe if you could give it one more test to be sure? |
|
Oops, I didn't realised that supabase/storage#127 hadn't been merged yet. Since @joshenlim said it worked locally, let's just merge, deploy to staging and test there? |
|
Sounds good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple non-breaking change that adds the new search param (added in supabase/storage#127) to the list function.