Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use http.Agent to speed up S3 calls #5

Closed
inian opened this issue Mar 30, 2021 · 2 comments
Closed

Use http.Agent to speed up S3 calls #5

inian opened this issue Mar 30, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@inian
Copy link
Member

inian commented Mar 30, 2021

A http agent can be used to keep a set of connections open to S3. By default, a new connection is created each time S3 is accessed which is not ideal.

https://docs.aws.amazon.com/sdk-for-javascript/v2/developer-guide/node-reusing-connections.html

@inian inian added the enhancement New feature or request label Mar 30, 2021
@logikaljay
Copy link

logikaljay commented May 17, 2021

@inian It appears as if keepAlive: true is the default in the NodeHttpHandler that the s3-client uses:

https://github.com/aws/aws-sdk-js-v3/blob/49e2d61c809d20ae444d49c7f6c4e997da7cca74/packages/node-http-handler/src/node-http-handler.ts#L44-L48

@inian
Copy link
Member Author

inian commented May 18, 2021

You are right @logikaljay :) This was required for their v2 sdk but looks like they have better defaults now.

@inian inian closed this as completed May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants