Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gotrue): catch some errors in signOut #501

Merged
merged 3 commits into from
Jun 6, 2023
Merged

fix(gotrue): catch some errors in signOut #501

merged 3 commits into from
Jun 6, 2023

Conversation

Vinzent03
Copy link
Collaborator

close #500
I'm catching specifc errors on sign out like in gotrue-js to prevent errors being thrown in signOut().

@Vinzent03 Vinzent03 requested a review from dshukertjr June 4, 2023 20:00
Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

packages/gotrue/lib/src/gotrue_client.dart Outdated Show resolved Hide resolved
Vinzent03 and others added 2 commits June 5, 2023 11:31
Co-authored-by: Tyler <18113850+dshukertjr@users.noreply.github.com>
Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!

@Vinzent03 Vinzent03 merged commit 03fa8be into main Jun 6, 2023
10 checks passed
@Vinzent03 Vinzent03 deleted the fix/signOut branch June 6, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider expose _removeSession function
2 participants