Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gotrue): Add missing members on User json serialization #512

Merged
merged 10 commits into from
Jun 13, 2023

Conversation

dshukertjr
Copy link
Member

@dshukertjr dshukertjr commented Jun 12, 2023

What kind of change does this PR introduce?

Because some members are missing from the Session object and its sub members, session that is recovered from local storage is missing some informations such as MFA AAL. This PR fixes the issue.

  • Adds missing members on User object json serialization
  • Adds missing members on == operator and hashcode definitions for Session and its sub property classes
  • Adds a test to try out json serialization & deserialization after signing in using MFA

@dshukertjr dshukertjr changed the title fix(gotrue): fix(gotrue): Add missing members on User json serializaion Jun 12, 2023
@dshukertjr dshukertjr changed the title fix(gotrue): Add missing members on User json serializaion fix(gotrue): Add missing members on User json serialization Jun 12, 2023
@dshukertjr dshukertjr marked this pull request as ready for review June 12, 2023 05:14
@dshukertjr dshukertjr marked this pull request as draft June 12, 2023 05:14
@dshukertjr dshukertjr marked this pull request as ready for review June 12, 2023 15:15
@dshukertjr dshukertjr merged commit 70cc835 into main Jun 13, 2023
10 checks passed
@dshukertjr dshukertjr deleted the fix/auth-request branch June 13, 2023 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants