Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gotrue): add accessToken to signInWithIdToken method #520

Merged
merged 4 commits into from
Jun 23, 2023
Merged

feat(gotrue): add accessToken to signInWithIdToken method #520

merged 4 commits into from
Jun 23, 2023

Conversation

dshukertjr
Copy link
Member

@dshukertjr dshukertjr commented Jun 23, 2023 •
edited
Loading

What kind of change does this PR introduce?

Adds accessToken parameter to signInWithIdToken method.

Related supabase/auth-js#690
Related #399

@dshukertjr dshukertjr mentioned this pull request Jun 23, 2023
Merged
@Vinzent03
Copy link
Collaborator

I don't really understand the documentation from gotrue-js for access_token, because I've never worked with native auth or similar, but I guess this should also be included in our doc.

If the ID token contains an at_hash claim, then the hash of this value is compared to the value in the ID token.

@dshukertjr
Copy link
Member Author

@Vinzent03 Thanks! I've added it!

@dshukertjr @Vinzent03
Update packages/gotrue/lib/src/gotrue_client.dart
5c628d7 
Co-authored-by: Vinzent <vinzent03@proton.me>
@dshukertjr dshukertjr merged commit 4dcd596 into main Jun 23, 2023
10 checks passed
@dshukertjr dshukertjr deleted the feat/accessToken branch June 23, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vinzent03 Vinzent03 Vinzent03 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dshukertjr @Vinzent03