Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gotrue): add WhatsApp support for OTP login #613

Merged
merged 5 commits into from
Sep 4, 2023
Merged

Conversation

dshukertjr
Copy link
Member

What kind of change does this PR introduce?

Adds WhatsApp support for OTP login

JS implementation are the following:

@Vinzent03
Copy link
Collaborator

Isn't the implementation for signUp() missing? And what about resend()? js doesn't have it implemented, but is it because the server doesn't support it, or they forgot it?

@dshukertjr
Copy link
Member Author

dshukertjr commented Sep 3, 2023

Isn't the implementation for signUp() missing?

Done.

js doesn't have it implemented, but is it because the server doesn't support it, or they forgot it?

Maybe. Left a comment for the auth team. We can always add it on Dart SDK later if the JS SDK adds it, so let's not worry too much about it.

dshukertjr and others added 2 commits September 3, 2023 22:26
Co-authored-by: Bruno D'Luka <45696119+bdlukaa@users.noreply.github.com>
@dshukertjr dshukertjr merged commit 40da5be into main Sep 4, 2023
8 of 10 checks passed
@dshukertjr dshukertjr deleted the feat/whatsapp-otp branch September 4, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants