refactor!: create package specific configs #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vinzent03
changed the title
dshukertjr
reviewed
Sep 25, 2023
There was a problem hiding this comment.
Thanks for the amazing work! I had one little thing about naming conventions, but other than that it looks amazing. On your point about removing SupabaseAuth class, I am with you, and I think we can remove it and migrate all the functinalities to Supabase class!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Changes
supabaseandsupabase_flutterSupabaseAuth.initializeas internal as I see no reason to manually initialize. It depends onSupabase.instanceso it can't be initialized alone either.This aligns a bit with how supabase-js does this, but I've done the naming a bit different.
Actually, I noticed there is not really a reason for a global
SupabaseAuth.instance, because it only provides access to the localstorage used. So I would be open to remove it and instead make it a simple object of theSupabaseclass insupabase_flutter.