Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build a Dart web app due to dependency on dart:io in gotrue 1.12.3 #658

Closed
kaboc opened this issue Oct 5, 2023 · 2 comments · Fixed by #659
Closed

Cannot build a Dart web app due to dependency on dart:io in gotrue 1.12.3 #658

kaboc opened this issue Oct 5, 2023 · 2 comments · Fixed by #659
Labels
bug Something isn't working

Comments

@kaboc
Copy link
Contributor

kaboc commented Oct 5, 2023

Describe the bug

Thank you for fixing the issue #641 I reported. Dependency on universal_io was certainly removed by #653. However, gotrue_client.dart now depends on dart:io and it has caused another issue similar to #641.

[INFO] Serving `web` on http://127.0.0.1:8080
[WARNING] build_web_compilers:entrypoint on web/main.dart: Skipping compiling bug|web/main.dart with ddc because some of its
transitive libraries have sdk dependencies that not supported on this platform:

gotrue|lib/src/gotrue_client.dart

https://github.com/dart-lang/build/blob/master/docs/faq.md#how-can-i-resolve-skipped-compiling-warnings

To Reproduce

Follow the steps written in #641.

Expected behavior

Pure Dart web apps using Supabase run without any issue.

Screenshots

N/A

Version (please complete the following information):

└── supabase 1.11.8
    ├── functions_client 1.3.2
    ├── gotrue 1.12.3
    ├── postgrest 1.5.1
    ├── realtime_client 1.3.0
    ├── storage_client 1.5.3
@kaboc kaboc added the bug Something isn't working label Oct 5, 2023
@Vinzent03
Copy link
Collaborator

I could have sworn I tested gotrue as well, but doesn't seem so. It doesn't even use dart:io really, but is only imported for a now outdated comment.
I'm unsure if we want to do another release just for that. For now you can simply edit that file yourself locally and remove the dart:io import as it's no longer used.

@kaboc
Copy link
Contributor Author

kaboc commented Oct 5, 2023

@Vinzent03
I made a PR anyway. You can decide whether to release a new version only for the fix. I can use the local version with the bug fix for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants