fix(gotrue): allow empty session response for verifyOtp method #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshukertjr
commented
Oct 25, 2023
Comment on lines
-498
to
-501
| if (authResponse.session == null) { | ||
| throw AuthException( | ||
| 'An error occurred on token verification.', | ||
| ); |
There was a problem hiding this comment.
This piece of code is mirroring this js SDK code, but we actually need to allow empty session.
We shouldn't need the !data check equivalent here, because _fetch.request will throw if it did not have any response data.
DanMossa
approved these changes
Oct 25, 2023
dshukertjr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Calling
auth.verifyOtp()method with the 6-digit OTP returns anAuthResponsewithnullsession. The supabase_flutter SDK currently however does not allownullsession returned from theverifyOtp()method, but this PR enables empty session to be returned.