fix: PKCE flow not emitting password recovery event #744
Conversation
|
|
|
|
||
| final session = authResponse.session; | ||
| if (session != null) { |
There was a problem hiding this comment.
Got rid of this check for session.
The signature of the return type on the js SDK guarantees that there is a session, so not sure why the js SDK has the check for session there.
https://github.com/supabase/gotrue-js/blob/master/src/GoTrueClient.ts#L534
|
@Vinzent03 |
| if (session == null) { | ||
| throw AuthPKCEGrantCodeExchangeError( | ||
| 'No session found for the auth code.'); | ||
| } | ||
|
|
||
| return AuthSessionUrlResponse(session: session, redirectType: null); |
There was a problem hiding this comment.
The result of exchangeCodeForSession can directly be returned. Currently, redirectType is still null.
There was a problem hiding this comment.
Should have caught that one myself. Should be fixed now!
What kind of change does this PR introduce?
Currently with PKCE flow,
passwordRecoveryauth event is not emitted for email password reset flow. This PR fixes it.What is the current behavior?
signInevent is emitted after clicking on the link sent to the email.What is the new behavior?
passwordRecoveryevent is emitted after opening the link sent to the email.Additional context
Fixes #664