feat(postgrest): Add toJson() method to PostgrestException to allow serialization
#783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshukertjr
changed the title
toJson() method to PostgrestException to allow serialization
dshukertjr
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Make PostgrestException serialisable by implementing the toJson method.
What is the current behavior?
I was having some issues due to PostgrestException, since I keep track of errors in the Redux store, and persist it. TBH, I was thinking I do not really want to store an exception as is or display it to the user directly, but I would like not to lose the information, maybe embed it in a user-friendly error, but keep the option to send it to the backend (e.g. via Sentry). So serialisation would be nice to have!
What is the new behavior?
It just implements the toJson. I feel this didn't really need a test, but I can add serialisation/deserialisation roundtrip if you like ✌️
Thanks!