refactor: Remove hive dependency and add instructinos to migration from v1 while persisting the auth state #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om v1 while persisting the auth state
DanMossa
approved these changes
Feb 1, 2024
Vinzent03
reviewed
Feb 1, 2024
Vinzent03
reviewed
Feb 1, 2024
Co-authored-by: Vinzent <vinzent03@proton.me>
|
We should link to the upgrade guide at least in the changelog file of supabase_flutter as well. |
dshukertjr
commented
Feb 3, 2024
Vinzent03
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR removes the Hive dependency. We said we eventually remove the Hive dependency when we first implemented the automatic migration code. I personally was thinking of keeping the migration code around longer something like 5 or 6 months, and it has only been a month and a half since v2 of supabase_fluter has been published. However, Hive is currently working on a complete rewrite, and it might be good to remove its dependency before they release a stable version of it. I'm open to comments about this PR though.
If this PR gets merged, I will add a similar section about migrating auth from v1 to v2 in the upgrade guide as well.
Closes #812