Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Weak password throws AuthWeakPasswordException. #897

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

dshukertjr
Copy link
Member

What kind of change does this PR introduce?

Fixes a bug.

What is the current behavior?

Currently a format exception with message type 'List<dynamic>' is not a subtype of type 'List<String>' is thrown when performing signUp, password update with a week password.

What is the new behavior?

AuthWeakPasswordException is properly thrown when performing signUp/ password update with a week password.

Additional context

fixes #891

@dshukertjr dshukertjr changed the title fix: week password throws the correct exception fix: week password throws AuthWeakPasswordException. Apr 23, 2024
@dshukertjr dshukertjr changed the title fix: week password throws AuthWeakPasswordException. fix: Weak password throws AuthWeakPasswordException. Apr 23, 2024
@dshukertjr dshukertjr merged commit 4f5b853 into main Apr 23, 2024
10 of 11 checks passed
@dshukertjr dshukertjr deleted the fix/week-password branch April 23, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

auth: updateUser throws TypeError when new password is too short
3 participants