feat(functions): Invoke function with custom query params #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cteq3132
changed the title
Cteq3132
changed the title
dshukertjr
reviewed
May 13, 2024
Vinzent03
reviewed
May 13, 2024
| @@ -71,11 +71,13 @@ class FunctionsClient { | |||
| String functionName, { | |||
| Map<String, String>? headers, | |||
| Map<String, dynamic>? body, | |||
| Map<String, String>? queryParameters, | |||
There was a problem hiding this comment.
From the Uri constructor documentation
A value in the map must be either null, a string, or an Iterable of strings. An iterable corresponds to multiple values for the same key, and an empty iterable or null corresponds to no value for the key.
So I think we could adapt the same type and use Map<String,dynamic> instead of Map<String,String> for the query parameters.
There was a problem hiding this comment.
Yes that's a good point, I'm updating this part right now.
dshukertjr
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Adding query parameters support for edge functions.
Closes #924
Additional context
Largely inspired from supabase/supabase-swift#376.
cc @dshukertjr