Use custom headers in every client #311
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
What is the current behavior?
Since #218 custom headers passed to the
SupabaseClient
constructor are passed on to theGoTrueClient
.However they are not passed on to the
PostgestClient
,SupabaseStorageClient
andSupabaseQueryBuilder
, although implied by the param description:supabase-js/src/SupabaseClient.ts
Line 45 in 5f7f3d5
What is the new behavior?
Headers passed through the
options.headers
parameter of the constructor are now stored in a new protected variableheaders
. Since all clients mentioned above call the private method_getAuthHeaders
I decided to inject the custom headers here, together with the default headers that were already injected inside this method.Additional context
I also created a very minimal test case, just to be sure the
_getAuthHeaders
method indeed returns the custom headers. I'm not an expert on Jest, so as far as convention goes there might be more optimal ways to test the functionality this PR introduces.Closes #166