Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export types for use by downstream librarys #97

Closed
calendee opened this issue Dec 9, 2020 · 1 comment
Closed

Export types for use by downstream librarys #97

calendee opened this issue Dec 9, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@calendee
Copy link
Contributor

calendee commented Dec 9, 2020

Feature request

Is your feature request related to a problem? Please describe.

Yes. Because the supabase-js does not export all types from the gotrue-js nor realtime-js libraries, client side developers cannot fully type their projects.

For example, you cannot do the following without these additional exports:

const subscriptionRef = useRef<null | RealtimeSubscription>(null)

or

.on('*', (payload: SupabaseRealtimePayload<Todos>) => {

or

const [supabase, setSupabase] = useState<undefined | SupabaseClient>()

Describe the solution you'd like

Export additional types for client side use

Describe alternatives you've considered

None

Additional context

Related: supabase/auth-js#28.

@calendee calendee added the enhancement New feature or request label Dec 9, 2020
@kiwicopple
Copy link
Member

@calendee thanks for sorting this - gotrue-js was released on v1.9.0

https://github.com/supabase/gotrue-js/releases/tag/v1.9.0

This one is going out on v1.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants