fix(auth): add missing is_anonymous field #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grdsdev
commented
Apr 26, 2024
Sources/Auth/Types.swift
Outdated
| self.role = try container.decodeIfPresent(String.self, forKey: .role) | ||
| self.updatedAt = try container.decode(Date.self, forKey: .updatedAt) | ||
| self.identities = try container.decodeIfPresent([UserIdentity].self, forKey: .identities) | ||
| self.isAnonymous = try container.decodeIfPresent(Bool.self, forKey: .isAnonymous) ?? false |
There was a problem hiding this comment.
Here is the fallback
hf
approved these changes
Apr 26, 2024
kangmingtay
approved these changes
Apr 26, 2024
grdsdev
force-pushed
the
fix/is_anonymous
branch
from
b851ed1
to
ac1a8a1
Compare
J0
approved these changes
Apr 26, 2024
dshukertjr
approved these changes
Apr 26, 2024
It should be a flaky test, but it is consistently failing for this PR, I'll try to fix it before merging it. |
grdsdev
force-pushed
the
fix/is_anonymous
branch
from
471dc6d
to
900d26c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Close #354
What is the current behavior?
Userobject does not have aisAnonymousfield.What is the new behavior?
Add missing
isAnonymous, and default it to false for backward compatibility.Additional context
Add any other context or screenshots.