Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript Support? #122

Closed
1 of 4 tasks
CoLdAs1cE opened this issue Jul 25, 2020 · 9 comments · Fixed by #141
Closed
1 of 4 tasks

TypeScript Support? #122

CoLdAs1cE opened this issue Jul 25, 2020 · 9 comments · Fixed by #141
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@CoLdAs1cE
Copy link

CoLdAs1cE commented Jul 25, 2020

  • I'm submitting a ...
  • feature request
  • question about the decisions made in the repository
  • bug report
  • question about how to use this project
  • Summary
    i only use typescript,
    there was no d.ts included and no @types in npm,
    is it possible to add?
@CoLdAs1cE CoLdAs1cE changed the title Typescript support? TypeScript support? Jul 27, 2020
@CoLdAs1cE CoLdAs1cE changed the title TypeScript support? TypeScript Support? Jul 27, 2020
@kiwicopple
Copy link
Member

Hey @CoLdAs1cE thanks for the patience - end of month so we've been busy releasing.

Surprisingly you're the first person to ask for this. We're trying to ship fast, so we've been very focused on some of the bigger features. Regardless, I think this is a good idea. I'll keep it open and see if anyone in the community is keep to contribute, but if it isn't picked up, we can add it soon

Thanks for taking the time to stop in!

@kiwicopple kiwicopple added the good first issue Good for newcomers label Jul 31, 2020
@CoLdAs1cE
Copy link
Author

^^, i did search around but didn't see any issue for it or any solution. So i tough since u guys are actively updating, this was not noticed or in any ones thoughts at all. So since many use typescript i though i should let you guys know :)

@hgranthorner
Copy link

I wouldn't doing this for the supabase-js library, I've been using it a fair bit.

@kiwicopple
Copy link
Member

That would be amazing @hgranthorner, thanks for offering. If you need any help just let us know. Happy to add you to our slack if you have anything to discuss

@awalias
Copy link
Member

awalias commented Aug 9, 2020

https://github.com/manifoldco/swagger-to-ts postgrest open-api spec to TS shared by @thorsten-stripe

@awalias awalias added the enhancement New feature or request label Aug 9, 2020
@awalias
Copy link
Member

awalias commented Aug 9, 2020

adding link to Supabase-js source for anyone willing to take this on

@thorwebdev
Copy link
Member

Might also be helpful to look at how knex.js is doing this:

@thorwebdev
Copy link
Member

@CoLdAs1cE @hgranthorner we've started work on type definitions here that should be in a pretty usable state. We'd love for you to test it out and provide feedback. You can just copy the content from the index.d.ts file into your project at node_modules/@supabase/supabase-js/lib/index.d.ts.

Feel free to provide feedback directly on the PR: supabase/supabase-js#18. Thanks :)

Here the preliminary docs: https://deploy-preview-141--supabase.netlify.app/docs/library/getting-started/#usage-with-typescript

@kiwicopple
Copy link
Member

❤️ . new docs

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants