Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error "Folder name contains invalid special characters" not displayed in the UI #20822

Closed
2 tasks done
onmax opened this issue Jan 29, 2024 · 7 comments
Closed
2 tasks done
Labels
bug Something isn't working frontend Related to supabase dashboard

Comments

@onmax
Copy link

onmax commented Jan 29, 2024

Bug report

  • I confirm this is a bug with Supabase, not with my own application.
  • I confirm I have searched the Docs, GitHub Discussions, and Discord.

Describe the bug

If you create a folder with a string like 2024-01-29T10:48:15.595Z, the Dashboard will thrown an error in the console, but nothing in the UI happens and it looks like everything went ok.

The message in the console says:

{
    "message": "Folder name contains invalid special characters"
}

To Reproduce

Steps to reproduce the behavior, please provide code snippets or a repository:

  1. Create a bucket in your application
  2. Open the console
  3. Create a folder with a name with special character. e.g. 2024-01-29T10:48:15.595Z
  4. In the console the error appears but not in the UI

Expected behavior

A toast with the error message

Screenshots

If applicable, add screenshots to help explain your problem.

System information

  • OS: Windows
  • Browser (if applies) chrome
  • Version of supabase-js: [e.g. 6.0.2]
  • Version of Node.js: [e.g. 10.10.0]

Additional context

supabase/supabase-js#960

@onmax onmax added the bug Something isn't working label Jan 29, 2024
@GaryAustin1 GaryAustin1 added the frontend Related to supabase dashboard label Jan 29, 2024
@Hallidayo
Copy link
Contributor

Hi @onmax, I've just tried the above and I seem to get a toast error when I try to create the folder, Are you experiencing the same now?

@onmax
Copy link
Author

onmax commented Feb 7, 2024

Now it allows me to change the name. So there is no issue whatsoever. I will close it. Thanks 👍

@onmax onmax closed this as completed Feb 7, 2024
@onmax
Copy link
Author

onmax commented Feb 7, 2024

Sorry. I tried to create a folder inside a folder with a name with ':', but it failed:

image

@onmax onmax reopened this Feb 7, 2024
@joshenlim
Copy link
Member

hey there @onmax - could you attach a screen recording for this bug? I tried to reproduce on production but can't seem to do so - the error message shows up properly
image

@joshenlim
Copy link
Member

I'm gonna go ahead to close this ticket for now as I'm unable to reproduce this issue but please do feel free to let us know otherwise! 🙏

@onmax
Copy link
Author

onmax commented Feb 15, 2024

Hey, sorry, I missed your message:

Here you can see a screen recording on Brave

brave_PeVuoFrNsG.mp4

In the video you can not see it, but I clicked 'Enter' a few times

@joshenlim
Copy link
Member

joshenlim commented Feb 16, 2024

Ahh hmm okay this is a odd one, it seems like our usage of react-hot-toast isn't working for Brave browser specifically so you probably aren't able to see any toast notifications at all with the browser - i'll see if there's any quick fix for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Related to supabase dashboard
Projects
None yet
Development

No branches or pull requests

4 participants