This repository has been archived by the owner on Mar 10, 2024. It is now read-only.
feat: Sequence integration tests #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
tonyxiao
requested review from
tomkit,
lucasmarshall,
asdfryan and
george-xing
as code owners
asdfryan
suggested changes
Nov 2, 2023
asdfryan
reviewed
Nov 2, 2023
asdfryan
reviewed
Nov 2, 2023
|
Done for both |
asdfryan
reviewed
Nov 2, 2023
| ); | ||
| expect(response.status).toEqual(201); | ||
| expect(response.data.record?.id).toBeTruthy(); | ||
| addedObjects.push({ |
There was a problem hiding this comment.
Does this get cleaned up at the end even if there are active contacts on it?
There was a problem hiding this comment.
Yes, it appears so.
There was a problem hiding this comment.
Though delete is only supported in outreach api though.
There was a problem hiding this comment.
This is salesloft
And for apollo I don't think there is delete at all, only archive.
asdfryan
reviewed
Nov 2, 2023
asdfryan
approved these changes
Nov 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: ####
[Describe your change here]
Test Plan
[Describe test plan here]
Deployment instructions
[Add any special deployment instructions here]