This repository has been archived by the owner on Mar 10, 2024. It is now read-only.
feat: get creating, updating, deleting Integrations working #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkit
requested review from
lucasmarshall,
albertyfwu,
asdfryan and
george-xing
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
tomkit
commented
Mar 10, 2023
| action={ | ||
| <Switch | ||
| checked={enabled} | ||
| checked={integration?.isEnabled} |
| subheader={ | ||
| <Stack direction="column"> | ||
| <Typography>{name}</Typography> | ||
| <Typography fontSize={12}>{status === 'auth-only' ? status : category.toUpperCase()}</Typography> |
There was a problem hiding this comment.
add in integration category
| const updatedIntegrations = [...existingIntegrations, newIntegration]; | ||
|
|
||
| mutate(updatedIntegrations, false); | ||
| mutateIntegration(createRemoteIntegration(newIntegration), false); |
There was a problem hiding this comment.
Following the pattern from the linked SWR reading for now
| label: 'Active', | ||
| value: 'active', | ||
| label: 'Installed', | ||
| value: 'installed', |
There was a problem hiding this comment.
Renaming to Installed since you can have existing but disabled integrations
| <Typography variant="body2" noWrap> | ||
| <Card variant="outlined" className="h-32"> | ||
| <Stack> | ||
| <CardHeader avatar={icon} subheader={title} /> |
There was a problem hiding this comment.
Make use of mui's CardHeader, CardContent so you get responsive for free
| </FormControl> | ||
| </Box> | ||
| ); | ||
| } |
There was a problem hiding this comment.
Used on sync log page
| </Grid> | ||
| </CardContent> | ||
| </Card> | ||
| </Box> |
There was a problem hiding this comment.
Moved from the dashboard page
| oauth_client_secret: 941b846a-5a8c-48b8-b0e1-41b6d4bc4f1a | ||
| - sync: | ||
| - period_ms: 60000 | ||
| - remote_provider_app_id: my_app_id |
tomkit
force-pushed
the
integration_changes
branch
4 times, most recently
from
92d5053
to
9e4779c
Compare
asdfryan
reviewed
Mar 10, 2023
| export const APPLICATION_ID = 'a4398523-03a2-42dd-9681-c91e3e2efaf4'; | ||
|
|
||
| // TODO: use Supaglue TS client | ||
| export async function updateRemoteIntegration(data: any) { |
asdfryan
reviewed
Mar 10, 2023
| // TODO: get this on the server-side from the session | ||
| export const APPLICATION_ID = 'a4398523-03a2-42dd-9681-c91e3e2efaf4'; | ||
|
|
||
| // TODO: use Supaglue TS client |
There was a problem hiding this comment.
Most of this file can be DRYed
asdfryan
reviewed
Mar 10, 2023
| }} | ||
| > | ||
| Cancel | ||
| </Button>{' '} |
asdfryan
reviewed
Mar 10, 2023
| const newIntegration = { | ||
| ...integration, | ||
| config: { | ||
| providerAppId: '', |
There was a problem hiding this comment.
Why is this line necessary? Does it get overridden by the next line?
asdfryan
reviewed
Mar 10, 2023
| oauthScopes: oauthScopes.split(','), | ||
| }, | ||
| sync: { | ||
| periodMs: 60 * 60 * 1000, |
asdfryan
reviewed
Mar 10, 2023
| {providerToIcon(integrationCardInfo.providerName)} | ||
| <Typography variant="subtitle1">{integrationCardInfo.name}</Typography> | ||
| <Stack direction="row" className="items-center justify-center gap-2"> | ||
| {providerToIcon(integrationCardInfo.providerName, 35)} |
asdfryan
reviewed
Mar 10, 2023
|
|
||
| const { trigger } = useSWRMutation('/mgmt/v1/integrations', sendRequest); | ||
| const { mutate: mutateIntegration } = useIntegration(integration?.id); | ||
| const { integrations: existingIntegrations = [], mutate } = useIntegrations(); | ||
|
|
||
| useEffect(() => { | ||
| setClientId(integration?.config?.oauth?.credentials?.oauthClientId); |
There was a problem hiding this comment.
Looks like integration is already passed in as a prop -- why do we need to do this?
tomkit
force-pushed
the
integration_changes
branch
5 times, most recently
from
dfb81b1
to
841ac81
Compare
tomkit
force-pushed
the
integration_changes
branch
from
841ac81
to
54d5c3c
Compare
asdfryan
approved these changes
Mar 11, 2023
tomkit
changed the title
tomkit
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration: addsis_enabledand makesconfigoptionaluseSWR'smutateto fetch and make updatesSWR related reading for using mutating local and remote state:
Other:
CardforMetricCardrather thanGridActivetab toInstalledApplication 1toYour application