Feature/seamless immutable #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @joeyfigaro for working on this. Can you format the code by following this project's eslint rules? |
|
@supasate definitely—should've checked before putting it up. I'll have those changes up shortly. 👍 |
|
@supasate I didn't find any problems outside of package.json and .eslintrc using tabs instead of spaces—did you happen to see anything else? Steps I took:
Got zero results for both. |
supasate
reviewed
Sep 2, 2018
test/ConnectedRouter.test.js
Outdated
| @@ -38,18 +39,18 @@ describe('ConnectedRouter', () => { | |||
| props = { | |||
| action: 'POP', | |||
| location: { | |||
| pathname: '/path/to/somewhere', | |||
| pathname: '/path/to/somewhere' | |||
supasate
reviewed
Sep 2, 2018
test/ConnectedRouter.test.js
Outdated
| }, | ||
| history, | ||
| history |
supasate
reviewed
Sep 2, 2018
test/ConnectedRouter.test.js
Outdated
| } | ||
|
|
||
| // Mock store | ||
| const mockStore = configureStore() | ||
| store = mockStore({ | ||
| router: { | ||
| action: 'POP', | ||
| location: props.history.location, | ||
| }, | ||
| location: props.history.location |
supasate
reviewed
Sep 2, 2018
test/ConnectedRouter.test.js
Outdated
| location: props.history.location, | ||
| }, | ||
| location: props.history.location | ||
| } |
supasate
reviewed
Sep 2, 2018
test/ConnectedRouter.test.js
Outdated
| @@ -252,9 +292,9 @@ const storeShape = PropTypes.shape({ | |||
|
|
|||
| ContextWrapper.propTypes = { | |||
| store: storeShape.isRequired, | |||
| children: PropTypes.element.isRequired, | |||
| children: PropTypes.element.isRequired | |||
supasate
reviewed
Sep 2, 2018
| } | ||
|
|
||
| ContextWrapper.childContextTypes = { | ||
| store: storeShape.isRequired, | ||
| store: storeShape.isRequired |
supasate
reviewed
Sep 2, 2018
test/reducer.test.js
Outdated
|
|
||
| describe('connectRouter', () => { | ||
| let mockHistory | ||
| let mockHistory |
There was a problem hiding this comment.
2 spaces instead of a tab. Please fix all of the followings.
supasate
requested changes
Sep 2, 2018
|
@supasate requested changes up! |
|
Thanks for your contribution! |
|
Awesome. Just saw this today. ⭐ I wish I could've helped then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented @chardskarth changes from #72 so we can get this guy merged. 🍰
Updated tests (rather naively) to get them to pass—updated the expectations of each failing test to match the expectations of the tests on master.