Don't update the deployment if we didn't start it (#4995)

super-linter · Dec 19, 2023 · 2d303aa · 2d303aa
1 parent 088bfe8
commit 2d303aa
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/.github/workflows/cd.yml b/.github/workflows/cd.yml
@@ -128,7 +128,11 @@ jobs:
 
       - name: Update ${{ matrix.images.environment }} Deployment
         uses: bobheadxi/deployments@v1.4.0
-        if: always()
+        # We depend on the 'deployment' step outputs, so we can't run this step
+        # if the 'deployment' step didn't run. This can happen if any step
+        # before the 'deployment' step fails. That's why 'always()' is not
+        # suitable here.
+        if: steps.deployment.conclusion != 'cancelled' && steps.deployment.conclusion != 'skipped'
         with:
           step: finish
           token: ${{ secrets.GITHUB_TOKEN }}