Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sqlfluff configuration #2184

Closed
withinfocus opened this issue Nov 27, 2021 · 5 comments · Fixed by #2361
Closed

Support sqlfluff configuration #2184

withinfocus opened this issue Nov 27, 2021 · 5 comments · Fixed by #2361
Labels
enhancement New feature or request

Comments

@withinfocus
Copy link

Is your feature request related to a problem? Please describe.

sqlfluff support isn't configurable largely due to their lack of support for passing in a config file path. Now that sqlfluff/sqlfluff#1986 is in place the Super-Linter can follow its common practices for allowing a config file to be ... configured.

Describe the solution you'd like

Add the normal variables and passthrough to the linter so sqlfluff configuration files can be used.

Describe alternatives you've considered

Disabling the sqlfluff linter due to compatibility problems with the defaults.

@withinfocus withinfocus added the enhancement New feature or request label Nov 27, 2021
@tunetheweb
Copy link
Contributor

tunetheweb commented Nov 27, 2021

(one of the SQLFluff maintainers here)

Thanks for raising this for tracking, but this will need to wait until 0.9.0 is released with that additional configuration option.

BTW I use the GitHub Super Linter quite happily with SQLFluff simply by placing the .sqlfluff config file in the top level directory containing my SQL file (right up to root project if necessary).

So currently I have the following:

.github
sql
 └ .sqlfluff
 └ example.sql
 └ project
    └ example2.sql
src
 └ other code

But agree it would be good to also allow this to be configured similar to other GitHub Super Linter configuration files like so, for those that prefer, once SQLFluff 0.9.0 is released:

.github
 └ linters
    └ .sqlfluff
sql
 └ example.sql
 └ project
    └ example2.sql
src

But using the first option means SQLFluff is configurable right now, even without that.

@withinfocus
Copy link
Author

Definitely on board with your second half there -- a lot of organizations (like mine) will want to have configuration for linting in a central location, and this generally better supports how the Super-Linter wants to work.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity.
It will be closed in 14 days if no further activity occurs.
Thank you for your contributions.

If you think this issue should stay open, please remove the O: stale 🤖 label or comment on the issue.

If you're a maintainer, you can stop the bot to mark this issue as stale in the future by adding the O: backlog 🤖 label`.

@github-actions github-actions bot added the O: stale 🤖 Stale issue/pr label Dec 28, 2021
@withinfocus
Copy link
Author

Still a need.

@tunetheweb
Copy link
Contributor

FYI opened #2361 to allow config file to be placed in usual location (.github/linters).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants