Allow SQLFluff configuration file to be used from standard location #2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tunetheweb
requested review from
admiralAwkbar,
ferrarimarco,
GaboFDC,
Hanse00,
lindluni,
nemchik and
zkoppert
as code owners
|
I'm struggling to build a local version to test this as don't use Docker much. |
This was referenced Jan 19, 2022
|
@tunetheweb I was just getting some cycles to go through the backlog and look at this one. You're the best! |
This was referenced Jan 24, 2022
sarahc23
pushed a commit
to 23andMe/super-linter
that referenced
this pull request
May 6, 2022
sarahc23
pushed a commit
to 23andMe/super-linter
that referenced
this pull request
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2184
Proposed Changes
SQLFluff 0.9.0 added a command line option to provide config file location.
This allows a config file to be places in the usual location (.github/linters) for those that want to manage it there.
Note SQLFluff does allow different configuration files to be used from each location, but if the file is explicitly specified as a command line option, then that takes precedence over any other config files. For this reason the provided config files is left commented out, so local files will be used.
Readiness Checklist
Author/Contributor
Reviewing Maintainer
breakingif this is a large fundamental changeautomation,bug,documentation,enhancement,infrastructure, orperformance