-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jscpd looks for code duplicate in images #3966
Comments
This issue has been automatically marked as stale because it has not had recent activity. If you think this issue should stay open, please remove the If you're a maintainer, you can stop the bot to mark this issue as stale in the future by adding the |
This issue has been automatically marked as stale because it has not had recent activity. If you think this issue should stay open, please remove the If you're a maintainer, you can stop the bot to mark this issue as stale in the future by adding the |
This issue has been automatically marked as stale because it has not had recent activity. If you think this issue should stay open, please remove the If you're a maintainer, you can stop the bot to mark this issue as stale in the future by adding the |
This issue has been automatically marked as stale because it has not had recent activity. If you think this issue should stay open, please remove the If you're a maintainer, you can stop the bot to mark this issue as stale in the future by adding the |
@fungiboletus Hi! Thanks for this report. Can you please share more about how you're running and configuring super-linter, so we can reproduce this? |
I believe I used the default configuration from the getting started section in the readme at the time of the issue. My repository had some images in it. |
Thanks for following up. For now, I'm going to close this because we don't have a reproduction case. |
Here you go: https://github.com/fungiboletus/superlint-jscpd-images It's an example repository with an image and the default configuration from the getting started section in the readme. The .webp image is processed by jscpd (and also gitleaks and textlint). |
@fungiboletus thanks for this example. I think this is a fair request. We should exclude at least the same files we exclude when using super-linter/lib/functions/buildFileList.sh Lines 111 to 131 in b9d7d8d
|
Given the changes in #5041, this should be solved. |
Describe the bug
jscpd looks for code duplicate in images, which takes some time with very little chances to find duplicates.
Expected behavior
Perhaps filenames with extensions from common binary files should be ignored by jscpd by default.
The text was updated successfully, but these errors were encountered: