-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run jscpd against the workspace #5041
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferrarimarco
added
enhancement
New feature or request
O: backlog 🤖
Backlog, stale ignores this label
labels
Dec 21, 2023
ferrarimarco
changed the title
feat: run jscpd, gitleaks against the workspace
feat: run jscpd, gitleaks against the workspace
Dec 21, 2023
ferrarimarco
changed the title
feat: run jscpd, gitleaks against the workspace
Run jscpd, gitleaks, textlint against the workspace
Dec 22, 2023
ferrarimarco
force-pushed
the
lint-workspace-gitleaks-jscpd
branch
9 times, most recently
from
December 22, 2023 16:32
68b43b0
to
0e3b14f
Compare
5 tasks
ferrarimarco
force-pushed
the
lint-workspace-gitleaks-jscpd
branch
7 times, most recently
from
December 22, 2023 20:23
f62738a
to
46a6360
Compare
(more context, originally posted in #4852 (comment)) This PR makes the following linters run against the entire workspace in one go, instead of linting file by file:
This approach also has the added benefit of letting users rely on the file listing and ignoring logic of each linter, so their configuration becomes more portable if they decide to run the same linter by other means. |
- Run jscpd, gitleaks, textlint against the entire workspace instead of running them over single files, one by one. - Implement a warning function for deprecated variables. - Deprecate the VALIDATE_JSCPD_ALL_CODEBASE variable. - Remove duplicate configuration files when they are the same as the ones we provide in TEMPLATES. - Add a missing tests for ansible-lint. - Move ANSIBLE_DIRECTORY configuration when running tests in buildFileList, where similar configs are. - Simplify ansible-lint test cases to include only what's necessary, and not an entire set of roles, playbooks, and inventory. - Write instructions about major upgrades in the upgrade guide.
ferrarimarco
force-pushed
the
lint-workspace-gitleaks-jscpd
branch
from
December 24, 2023 14:06
46a6360
to
b348508
Compare
ferrarimarco
added a commit
that referenced
this pull request
Jan 6, 2024
textlint was expensive to run because we added every file in the list of files to lint to FILE_ARRAY_NATURAL_LANGUAGE. In #5041, we mitigated this issue but lost the ability to run textlint on changed files only. Given that textlint ignore files for which it doesn't have a plugin installed, and that we don't currently install additional plugins besides the default ones to lint markdown files and text files, we let textlint run on these files only, so we can have the feature to lint only changed files with this linter as well, back.
8 tasks
ferrarimarco
added a commit
that referenced
this pull request
Jan 6, 2024
textlint was expensive to run because we added every file in the list of files to lint to FILE_ARRAY_NATURAL_LANGUAGE. In #5041, we mitigated this issue but lost the ability to run textlint on changed files only. Given that textlint ignore files for which it doesn't have a plugin installed, and that we don't currently install additional plugins besides the default ones to lint markdown files and text files, we let textlint run on these files only, so we can have the feature to lint only changed files with this linter as well, back.
ferrarimarco
added a commit
that referenced
this pull request
Jan 9, 2024
textlint was expensive to run because we added every file in the list of files to lint to FILE_ARRAY_NATURAL_LANGUAGE. In #5041, we mitigated this issue but lost the ability to run textlint on changed files only. Given that textlint ignore files for which it doesn't have a plugin installed, and that we don't currently install additional plugins besides the default ones to lint markdown files and text files, we let textlint run on these files only, so we can have the feature to lint only changed files with this linter as well, back.
ferrarimarco
added a commit
that referenced
this pull request
Jan 10, 2024
textlint was expensive to run because we added every file in the list of files to lint to FILE_ARRAY_NATURAL_LANGUAGE. In #5041, we mitigated this issue but lost the ability to run textlint on changed files only. Given that textlint ignore files for which it doesn't have a plugin installed, and that we don't currently install additional plugins besides the default ones to lint markdown files and text files, we let textlint run on these files only, so we can have the feature to lint only changed files with this linter as well, back.
ferrarimarco
changed the title
Run jscpd, gitleaks, textlint against the workspace
Run jscpd, gitleaks against the workspace
Jan 15, 2024
ferrarimarco
changed the title
Run jscpd, gitleaks against the workspace
Run jscpd against the workspace
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking
big changes, potentially causes failure
enhancement
New feature or request
O: backlog 🤖
Backlog, stale ignores this label
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
gitleaks(not anymore, see Build the file list and run linters in parallel #5177),textlint(not anymore see Enable linting changed files with textlint #5100) against the entire workspace instead ofrunning them over single files, one by one.
VALIDATE_JSCPD_ALL_CODEBASE
variable.EXPERIMENTAL_BATCH_WORKER
variable, and related code, so we can implement a more scalable approach..github/linters
when they are the same as the ones we ship inTEMPLATES
.bad
tests for ansible-lint.ANSIBLE_DIRECTORY
configuration when running tests inbuildFileList
, where similar configs are.not an entire set of roles, playbooks, and inventory.
Readiness Checklist
In order to have this pull request merged, complete the following tasks.
Pull request author tasks
Super-linter maintainer tasks
breaking
if this change breaks compatibility with the previous released version.automation
,bug
,documentation
,enhancement
,infrastructure
.