Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint XSD files #5248

Closed
1 task done
Dosanyintolu1 opened this issue Feb 8, 2024 · 4 comments · Fixed by #5250 or #5209
Closed
1 task done

Lint XSD files #5248

Dosanyintolu1 opened this issue Feb 8, 2024 · 4 comments · Fixed by #5250 or #5209
Labels
enhancement New feature or request O: backlog 🤖 Backlog, stale ignores this label

Comments

@Dosanyintolu1
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

When I use the VALIDATE_XML, I always get a successful build even with multiple errors in the file.

Expected Behavior

I expect error outputs when malformed xsd files are linted.

Super-Linter version

v6.0.0

Relevant log output

none

Steps To Reproduce

  1. Include the following in the xsd file:
<?xml version = "1.0" encoding = "UTF-8"?>
<!-- $Header: /cvsroot/ebxmlrr/ebxmlrr-spec/misc/3.0/schema/rim.xsd,v 1.20 2005/02/03 19:28:15 farrukh_najmi Exp $ -->
<schema targetNamespace="urn:oasis:names:tc:ebxml-regrep:xsd:rim:3.0" 
  xmlns="http://www.w3.org/2001/XMLSchema" 
  xmlns:tns="urn:oasis:names:tc:ebxml-regrep:xsd:rim:3.0"
  xmlns:xml="http://www.w3.org/XML/1998/names=
      <maxLength value="4"/>
  1. Push to github and run the action.
  2. Below is my output with the above xml in my xsd file.
    Screenshot 2024-02-08 at 5 48 26 PM

Anything else?

No response

@Dosanyintolu1 Dosanyintolu1 added the bug Something isn't working label Feb 8, 2024
@ferrarimarco
Copy link
Collaborator

Hi @Dosanyintolu1 !

Include the following in the xsd file: what extension does the file have?

In the current implementation, super-linter lints files with a .xml extension using xmllint. We can probably check .xsd files as well. xmllint seems to support this, at least for syntax.

@ferrarimarco ferrarimarco added enhancement New feature or request O: backlog 🤖 Backlog, stale ignores this label and removed bug Something isn't working labels Feb 9, 2024
@ferrarimarco ferrarimarco changed the title XML Linter Issue Lint XSD files Feb 9, 2024
ferrarimarco added a commit that referenced this issue Feb 9, 2024
Lint XSD files with xmllint

Close #5248
@ferrarimarco ferrarimarco mentioned this issue Feb 9, 2024
8 tasks
@ferrarimarco
Copy link
Collaborator

#5250 should take care of this

@Dosanyintolu1
Copy link
Author

@ferrarimarco Sorry for the late response. But yes, its an xsd extension. Now you've created the PR to fix this, do I have to wait for it to be merged before I can test again ?

@ferrarimarco
Copy link
Collaborator

No worries! You're correct :)

github-merge-queue bot pushed a commit that referenced this issue Feb 9, 2024
Lint XSD files with xmllint

Close #5248
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants