-
Notifications
You must be signed in to change notification settings - Fork 941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't require full Git environment validation when users enable IGNORE_GITIGNORED_FILES #5383
Comments
Hi @Emmanuel-Mekonnen ! We have a few tests that match how you're invoking super-linter already, and they don't reproduce the issue you're facing. Can you try running |
Running 6.3.0 is producing the same error. |
Running a more extensive command with debug:
I get the following logs:
|
Thanks for providing this log, it's helpful. You shouldn't hit that code path because you set Lines 742 to 749 in 770c355
So that condition should actually be This is indeed a bug. |
Is there a fix for this? I guess I could turn |
This comment was marked as duplicate.
This comment was marked as duplicate.
@MenszgUDoker’s comment with line breaks in a code fence > * [1] 2024-03-14 19:27:04 [INFO] --------------------------------------------
2024-03-14 19:27:04 [INFO] Gathering GitHub information...
2024-03-14 19:27:04 [INFO] RUN_LOCAL has been set to: true. Bypassing GitHub Actions variables...
2024-03-14 19:27:04 [INFO] Successfully validated GITHUB_WORKSPACE: /tmp/lint
2024-03-14 19:27:04 [DEBUG] Skip the initalization of GITHUB_SHA because we don't need it
2024-03-14 19:27:04 [DEBUG] Setting MULTI_STATUS to false because we are not running on GitHub Actions
2024-03-14 19:27:04 [DEBUG] Successfully detected the default branch for this repository: master
2024-03-14 19:27:04 [INFO] The default branch for this repository is set to: master
2024-03-14 19:27:04 [DEBUG] Skip GITHUB_TOKEN, GITHUB_REPOSITORY, and GITHUB_RUN_ID validation because we don't need these variables for GitHub Actions status reports. MULTI_STATUS: false
2024-03-14 19:27:05 [DEBUG] Configuring Git safe directories
2024-03-14 19:27:05 [DEBUG] Set /tmp/lint as a Git safe directory
2024-03-14 19:27:05 [DEBUG] Set /tmp/lint as a Git safe directory
2024-03-14 19:27:05 [DEBUG] Set /tmp/lint as a Git safe directory
2024-03-14 19:27:05 [DEBUG] TYPESCRIPT_STANDARD_TSCONFIG_FILE: /tmp/lint/tsconfig.json
2024-03-14 19:27:05 [DEBUG] R_RULES_FILE_PATH_IN_ROOT: /tmp/lint/.lintr
2024-03-14 19:27:05 [INFO] --------------------------------------------
2024-03-14 19:27:05 [INFO] Validating the configuration
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_ANSIBLE
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_ANSIBLE
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_BASH
2024-03-14 19:27:05 [DEBUG] VALIDATE_BASH has a valid boolean string value: true
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_BASH_EXEC
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_BASH_EXEC
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_CHECKOV
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_CHECKOV
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_CLANG_FORMAT
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_CLANG_FORMAT
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_CLOUDFORMATION
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_CLOUDFORMATION
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_CLOJURE
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_CLOJURE
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_COFFEESCRIPT
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_COFFEESCRIPT
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_CPP
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_CPP
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_CSS
2024-03-14 19:27:05 [DEBUG] VALIDATE_CSS has a valid boolean string value: true
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_DART
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_DART
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_DOCKERFILE_HADOLINT
2024-03-14 19:27:05 [DEBUG] VALIDATE_DOCKERFILE_HADOLINT has a valid boolean string value: true
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_EDITORCONFIG
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_EDITORCONFIG
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_GITHUB_ACTIONS
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_GITHUB_ACTIONS
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_GITLEAKS
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_GITLEAKS
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_GHERKIN
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_GHERKIN
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_GO
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_GO
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_GO_MODULES
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_GO_MODULES
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_GOOGLE_JAVA_FORMAT
2024-03-14 19:27:05 [DEBUG] VALIDATE_GOOGLE_JAVA_FORMAT has a valid boolean string value: true
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_GROOVY
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_GROOVY
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_HTML
2024-03-14 19:27:05 [DEBUG] VALIDATE_HTML has a valid boolean string value: true
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_JAVA
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_JAVA
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_JAVASCRIPT_ES
2024-03-14 19:27:05 [DEBUG] VALIDATE_JAVASCRIPT_ES has a valid boolean string value: true
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_JAVASCRIPT_STANDARD
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_JAVASCRIPT_STANDARD
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_JSCPD
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_JSCPD
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_JSON
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_JSON
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_JSONC
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_JSONC
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_JSX
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_JSX
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_KUBERNETES_KUBECONFORM
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_KUBERNETES_KUBECONFORM
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_KOTLIN
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_KOTLIN
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_LATEX
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_LATEX
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_LUA
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_LUA
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_MARKDOWN
2024-03-14 19:27:05 [DEBUG] VALIDATE_MARKDOWN has a valid boolean string value: true
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_NATURAL_LANGUAGE
2024-03-14 19:27:05 [DEBUG] VALIDATE_NATURAL_LANGUAGE has a valid boolean string value: true
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_OPENAPI
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_OPENAPI
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_PERL
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_PERL
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_PHP_BUILTIN
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_PHP_BUILTIN
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_PHP_PHPCS
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_PHP_PHPCS
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_PHP_PHPSTAN
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_PHP_PHPSTAN
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_PHP_PSALM
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_PHP_PSALM
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_PROTOBUF
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_PROTOBUF
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_PYTHON_BLACK
2024-03-14 19:27:05 [DEBUG] VALIDATE_PYTHON_BLACK has a valid boolean string value: true
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_PYTHON_PYLINT
2024-03-14 19:27:05 [DEBUG] VALIDATE_PYTHON_PYLINT has a valid boolean string value: true
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_PYTHON_FLAKE8
2024-03-14 19:27:05 [DEBUG] VALIDATE_PYTHON_FLAKE8 has a valid boolean string value: true
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_PYTHON_ISORT
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_PYTHON_ISORT
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_PYTHON_MYPY
2024-03-14 19:27:05 [DEBUG] VALIDATE_PYTHON_MYPY has a valid boolean string value: true
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_R
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_R
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_RAKU
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_RAKU
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_RENOVATE
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_RENOVATE
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_RUBY
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_RUBY
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_SCALAFMT
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_SCALAFMT
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_SHELL_SHFMT
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_SHELL_SHFMT
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_SNAKEMAKE_LINT
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_SNAKEMAKE_LINT
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_SNAKEMAKE_SNAKEFMT
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_SNAKEMAKE_SNAKEFMT
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_STATES
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_STATES
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_SQL
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_SQL
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_SQLFLUFF
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_SQLFLUFF
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_TEKTON
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_TEKTON
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_TERRAFORM_FMT
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_TERRAFORM_FMT
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_TERRAFORM_TFLINT
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_TERRAFORM_TFLINT
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_TERRAFORM_TERRASCAN
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_TERRAFORM_TERRASCAN
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_TERRAGRUNT
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_TERRAGRUNT
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_TSX
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_TSX
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_TYPESCRIPT_ES
2024-03-14 19:27:05 [DEBUG] VALIDATE_TYPESCRIPT_ES has a valid boolean string value: true
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_TYPESCRIPT_STANDARD
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_TYPESCRIPT_STANDARD
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_XML
2024-03-14 19:27:05 [DEBUG] Configuration didn't provide a custom value for VALIDATE_XML
2024-03-14 19:27:05 [DEBUG] Set VALIDATE_LANGUAGE while validating the configuration: VALIDATE_YAML
2024-03-14 19:27:05 [DEBUG] VALIDATE_YAML has a valid boolean string value: true
2024-03-14 19:27:05 [DEBUG] - Excluding [ANSIBLE] files in code base...
2024-03-14 19:27:05 [DEBUG] - Validating [BASH] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [BASH_EXEC] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [CHECKOV] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [CLANG_FORMAT] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [CLOUDFORMATION] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [CLOJURE] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [COFFEESCRIPT] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [CPP] files in code base...
2024-03-14 19:27:05 [DEBUG] - Validating [CSS] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [DART] files in code base...
2024-03-14 19:27:05 [DEBUG] - Validating [DOCKERFILE_HADOLINT] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [EDITORCONFIG] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [GITHUB_ACTIONS] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [GITLEAKS] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [GHERKIN] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [GO] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [GO_MODULES] files in code base...
2024-03-14 19:27:05 [DEBUG] - Validating [GOOGLE_JAVA_FORMAT] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [GROOVY] files in code base...
2024-03-14 19:27:05 [DEBUG] - Validating [HTML] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [JAVA] files in code base...
2024-03-14 19:27:05 [DEBUG] - Validating [JAVASCRIPT_ES] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [JAVASCRIPT_STANDARD] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [JSCPD] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [JSON] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [JSONC] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [JSX] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [KUBERNETES_KUBECONFORM] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [KOTLIN] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [LATEX] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [LUA] files in code base...
2024-03-14 19:27:05 [DEBUG] - Validating [MARKDOWN] files in code base...
2024-03-14 19:27:05 [DEBUG] - Validating [NATURAL_LANGUAGE] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [OPENAPI] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [PERL] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [PHP_BUILTIN] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [PHP_PHPCS] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [PHP_PHPSTAN] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [PHP_PSALM] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [PROTOBUF] files in code base...
2024-03-14 19:27:05 [DEBUG] - Validating [PYTHON_BLACK] files in code base...
2024-03-14 19:27:05 [DEBUG] - Validating [PYTHON_PYLINT] files in code base...
2024-03-14 19:27:05 [DEBUG] - Validating [PYTHON_FLAKE8] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [PYTHON_ISORT] files in code base...
2024-03-14 19:27:05 [DEBUG] - Validating [PYTHON_MYPY] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [R] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [RAKU] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [RENOVATE] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [RUBY] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [SCALAFMT] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [SHELL_SHFMT] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [SNAKEMAKE_LINT] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [SNAKEMAKE_SNAKEFMT] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [STATES] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [SQL] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [SQLFLUFF] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [TEKTON] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [TERRAFORM_FMT] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [TERRAFORM_TFLINT] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [TERRAFORM_TERRASCAN] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [TERRAGRUNT] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [TSX] files in code base...
2024-03-14 19:27:05 [DEBUG] - Validating [TYPESCRIPT_ES] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [TYPESCRIPT_STANDARD] files in code base...
2024-03-14 19:27:05 [DEBUG] - Excluding [XML] files in code base...
2024-03-14 19:27:05 [DEBUG] - Validating [YAML] files in code base...
2024-03-14 19:27:05 [DEBUG] Set ANSIBLE_DIRECTORY to the default: /tmp/lint/ansible
2024-03-14 19:27:05 [DEBUG] Validate the local Git environment
2024-03-14 19:27:05 [DEBUG] Check if /tmp/lint is a Git repository .git
2024-03-14 19:27:05 [DEBUG] /tmp/lint is a Git repository
2024-03-14 19:27:05 [DEBUG] Git branches: * master development
2024-03-14 19:27:05 [DEBUG] Git HEAD: commit fba885b1ba8863e5eb18a4b3f5f59158c88555fd Merge: 91db22abf 465807408 Author: Date: Thu Mar 14 15:22:24 2024 -0400 Merge remote-tracking branch 'origin/development' into master .gitignore | 1 + .gitlab/deploy.yml | 2 +- dev/package-lock.json | 74 ++++++++++++++++++++++++------------------- 3 files changed, 77 insertions(+), 55 deletions(-) /action/lib/functions/validation.sh: line 202: GITHUB_SHA: unbound variable
2024-03-14 19:27:05 [DEBUG] Captured exit code: 1
2024-03-14 19:27:05 [DEBUG] Removing temporary files and directories
2024-03-14 19:27:05 [DEBUG] LOG_FILE_PATH: /tmp/lint/super-linter.log
2024-03-14 19:27:05 [DEBUG] Skipping the moving of the log file from /tmp/tmp.mYCDBKFi5Q to /tmp/lint/super-linter.log |
I had a second look at this one. This validation check looks right to me: Lines 742 to 749 in 770c355
because if @MenszgUDoker can you please post an unedited debug log, so we can see what's going on? Thanks! PS: please, update to super-linter |
Closing for the lack of response :) |
Well, the question wasn't addressed to me, but I get the same error. I can certainly post my own log... Let me get back to you. |
If this is sufficient for you, let me know. |
Hi @hepcat72 ! Can you please update to the latest super-linter version, and set the Thanks! |
Pulling now. |
Sorry for the slow response. Got called away while it was running. The new version still has the error, and there is still no linting output:
|
@ferrarimarco, is this sufficient? It would be nice to be able to use the find algorithm again. It wasn't long after I started using it before we updated from superlinter 4.x, and then I couldn't lint with the find algorithm anymore... |
Ah! I get what's happening. You set Lines 742 to 749 in 770c355
Both reports show the same behavior, so I believe this is what we're experiencing here. We need to check if the workspace is a Git directory because we invoke super-linter/lib/functions/buildFileList.sh Lines 272 to 275 in c26430f
One could argue that we don't necessarily need to validate the entire Git environment for this check, but at least we need to check if we are in a Git repository or not. At minimum, we should have a clearer error message. The workaround is to avoid setting Let me reopen this while we think about a solution. Also, given this is working as expected, this is likely an enhancement request rather than a bug. |
I'm glad you worked out what's happening. If it's working as designed, then I would say you could consider the not catching the specific error case a bug, that is, if interpretable/understandable errors is a requirement. I don't think users would necessarily intuit that changing the way the tool finds files would have the side effect of changing whether superlinter changes its overall behavior as to whether it's dealing with a GitHub repo. Consider my use case: I simply want to lint new files before staging or commit. I.e. I don't want to check in files that have listing issues. I don't honestly know if staging would solve that concern, but I would point out that sometimes, a file name has to be changed as a part of the debugging process, e.g. case insensitive file systems and bugs related to substrings, and I often lint before I debug. Overall, it's just less overhead to be able to lint before |
Yeah, there's room for improvement here. Thanks for sharing the details about your use case. |
- Don't require Git SHA and branch validation when IGNORE_GITIGNORED_FILES=true because we only need to validate that the workspace is a Git repository in this case. Fix #5383
#5599 should take care of this. |
- Don't require Git SHA and branch validation when IGNORE_GITIGNORED_FILES=true because we only need to validate that the workspace is a Git repository in this case. Fix #5383
- Don't require Git SHA and branch validation when IGNORE_GITIGNORED_FILES=true because we only need to validate that the workspace is a Git repository in this case. Fix #5383
- Don't require Git SHA and branch validation when IGNORE_GITIGNORED_FILES=true because we only need to validate that the workspace is a Git repository in this case. Fix #5383
Is there an existing issue for this?
Current Behavior
Upgrading from v5 to v6 is resulting in .git /action/lib/functions/validation.sh: line 202: GITHUB_SHA: unbound variable error.
Expected Behavior
For super-linter container to run correctly.
Super-Linter version
Relevant log output
Steps To Reproduce
Running the following command
Error shows up locally and on Gitlab pipeline.
Downgrading to v5 fixes this issue.
Anything else?
No response
The text was updated successfully, but these errors were encountered: