Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No full Git validation when ignoring files #5599

Merged
merged 1 commit into from
Apr 30, 2024
Merged

No full Git validation when ignoring files #5599

merged 1 commit into from
Apr 30, 2024
+25 −3

Conversation

ferrarimarco
Copy link
Collaborator

@ferrarimarco ferrarimarco commented Apr 30, 2024 •
edited

Proposed changes

  • Don't require Git SHA and branch validation when IGNORE_GITIGNORED_FILES=true because we only need to validate that the workspace is a Git repository in this case.

Fix #5383

Readiness checklist

In order to have this pull request merged, complete the following tasks.

Pull request author tasks

  • I included all the needed documentation for this change.
  • I provided the necessary tests.
  • I squashed all the commits into a single commit.
  • I followed the Conventional Commit v1.0.0 spec.
  • I wrote the necessary upgrade instructions in the upgrade guide.
  • If this pull request is about and existing issue,
    I added the Fix #ISSUE_NUMBER label to the description of the pull request.

Super-linter maintainer tasks

  • Label as breaking if this change breaks compatibility with the previous released version.
  • Label as either: automation, bug, documentation, enhancement, infrastructure.

@ferrarimarco ferrarimarco added bug Something isn't working O: backlog 🤖 Backlog, stale ignores this label labels Apr 30, 2024
@ferrarimarco
Copy link
Collaborator Author

Once we merge #5345, the tests should pass.

@ferrarimarco ferrarimarco marked this pull request as ready for review April 30, 2024 12:05
@ferrarimarco ferrarimarco mentioned this pull request Apr 30, 2024
Closed
1 task
@ferrarimarco
fix: no full git validation when ignoring files
162490f 
- Don't require Git SHA and branch validation when
  IGNORE_GITIGNORED_FILES=true because we only need to validate that the
  workspace is a Git repository in this case.

Fix #5383
@ferrarimarco ferrarimarco merged commit 2bb8a0a into main Apr 30, 2024
100 checks passed
@ferrarimarco ferrarimarco deleted the fix-ignored-files branch April 30, 2024 15:58
@github-actions github-actions bot mentioned this pull request Apr 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zkoppert zkoppert Awaiting requested review from zkoppert zkoppert is a code owner

@Hanse00 Hanse00 Awaiting requested review from Hanse00 Hanse00 is a code owner

Assignees
No one assigned
Labels
bug Something isn't working O: backlog 🤖 Backlog, stale ignores this label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't require full Git environment validation when users enable IGNORE_GITIGNORED_FILES
1 participant
@ferrarimarco