Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update black binary to 21.9b0 #1909

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

jalaziz
Copy link
Contributor

@jalaziz jalaziz commented Aug 30, 2021

Release Notes

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@jalaziz
Copy link
Contributor Author

jalaziz commented Aug 31, 2021

This is currently broken as it seems like the latest black binary is throwing an error. See psf/black#2464.

@admiralAwkbar
Copy link
Collaborator

@jalaziz Looks like this resolved itself and since we have redeployed were up to date?

@jalaziz
Copy link
Contributor Author

jalaziz commented Sep 9, 2021

@jalaziz Looks like this resolved itself and since we have redeployed were up to date?

The issue was resolved, but black hasn't published new binaries as far as I can tell. I'm watching out for that to update this PR once it's been deployed.

That being said, it looks like snakefmt recently merged in the change that would allow black to be updated through pip. That being said, the binary version of black is probably still useful long term.

I don't believe super-linter is up-to-date though as the binary is still pointing to 21.7b0, unless i missed something? The 21.8b0 binary is certainly broken and it doesn't seem like black has republished it yet, so we might have to wait until the next release.

@jalaziz jalaziz changed the title Update black binary to 21.8b0 Update black binary to 21.9b0 Sep 14, 2021
@jalaziz
Copy link
Contributor Author

jalaziz commented Sep 14, 2021

@admiralAwkbar This PR should be good now.

@admiralAwkbar admiralAwkbar merged commit 0c13701 into super-linter:master Sep 14, 2021
@admiralAwkbar
Copy link
Collaborator

@jalaziz Thanks for keeping up with this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants