fix(R linting): try installing the R package before linting R language

[kpagacz]

• the tool used to lint the R language gives false positives for files inside an R library, which is not installed
• this change tries to naively install the package in the linted directory

Fixes #1910

I am not particularly experienced in Bash and this is my first PR to this repository, so I would welcome any guidance regarding styling, direction etc.

Proposed Changes

1. Given the R language files to lint, try to install the R package from the working directory.

Readiness Checklist

Author/Contributor

• If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

• Label as breaking if this is a large fundamental change
• Label as either automation, bug, documentation, enhancement, infrastructure, or performance

[admiralAwkbar]

@kpagacz
Sorry for such a delay on this. Have not had a lot of time lately and have been in maint mode.
Let me know if this looks good to you :)

thanks!

[admiralAwkbar]

@kpagacz
I'm not 100% sure how this command is working, but the other 2 make sense :)

So we do a quick check to see if we are validating R files, and that we do have R files to validate, then we run this block of code.

I set it to warn and not error as I'm guessing some people don't have build packages in their repo, and that would cause failures to install something that isn't there...

thoughts?

[kpagacz]

Didn't find the Additional Installs section when I was looking through the code. Thanks for moving it here and all the improvements. My inexperience in bash is certainly showing here.

I agree this line is the weakest link. R CMD build outputs a .tar.gz file with the built package but does not give any options to customize the target path. I can try to regex the line with .tar.gz from the standard output of R CMD build (because the output from the command contains a line with the target file name) and extract the file name that way. I am unsure what's the safest way to proceed here as well.

Do you have a preference?

[admiralAwkbar]

@kpagacz If you can give me some example code to run the r build command on, I should be able to get the last piece of this done :)
Just not familiar with the language, but if I had access to some test code I can write the last bash :)

[kpagacz]

Thank you very much for taking this over.

I created an empty R repository: https://github.com/kpagacz/r-test-package

You can clone it and then run the command R CMD build r-test-pacakge and R CMD INSTALL <path to the result of the first command>. Run the commands in the directory containing the r-test-package directory (given directory structure /path/to/repo/here/r-test-package run the commands in the 'here' directory).

[admiralAwkbar]

@kpagacz Thanks for the test code! Thats all I needed to get this right :)

SHould be able to merge once tests pass