Match AWS States file using "States" JSON key #1949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matching only on `"Resource": "arn` is too wide and will match also aws json policy files
t-botz
requested review from
admiralAwkbar,
ferrarimarco,
GaboFDC,
Hanse00,
jwiebalk,
nemchik and
zkoppert
as code owners
t-botz
commented
Sep 9, 2021
| @@ -203,8 +203,8 @@ DetectAWSStatesFIle() { | |||
| ############################### | |||
| # check if file has resources # | |||
| ############################### | |||
| if grep -q '"Resource": *"arn"*' "${FILE}"; then | |||
There was a problem hiding this comment.
"* at the end of the pattern seems unnecessary.
Thinking about it, x*, no matter x, at the beginning or the end of a grep pattern brings no value. That should probably be a lint rule in somewhere! :)
t-botz
changed the title
admiralAwkbar
previously approved these changes
Sep 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Matching only on
"Resource": "arnis too wide and will match also aws json policy files for example.Given the keys States and StartAt are required in any states file it makes sense to use one of them to narrow it down (why not even both...)
Readiness Checklist
Author/Contributor
Reviewing Maintainer
breakingif this is a large fundamental changeautomation,bug,documentation,enhancement,infrastructure, orperformance