Improve GITHUB_API_URL default value handling #2031
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Actions already has
GITHUB_API_URL
environment variable which contains GitHub API URL. We should be smart about overriding it and, if it exists and already has value, we should not override it.In addition, we should strip the last trailing slash (if it exists) from
GITHUB_API_URL
, as API calls already append the slash.This change allows running the action on GitHub Enterprise without the need to explicitly set
GITHUB_CUSTOM_API_URL
.Proposed Changes
GITHUB_CUSTOM_API_URL
exists, use its value as API URLGITHUB_CUSTOM_API_URL
does not exist, butGITHUB_API_URL
is already set, use its value as API URLGITHUB_CUSTOM_API_URL
norGITHUB_API_URL
is set, usehttps://api.github.com
as API URLGITHUB_API_URL
.Readiness Checklist
Author/Contributor
Reviewing Maintainer
breaking
if this is a large fundamental changeautomation
,bug
,documentation
,enhancement
,infrastructure
, orperformance