Adding scalafmt #2053
Merged
Adding scalafmt #2053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmherbst
requested review from
admiralAwkbar,
ferrarimarco,
GaboFDC,
Hanse00,
jwiebalk,
nemchik and
zkoppert
as code owners
|
@jmherbst Very nicely done! |
|
Thanks @admiralAwkbar ! Let me know what I need to do in order to correct/re-run this failure |
admiralAwkbar
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There isn't an active issue related to this PR, but https://github.com/github/super-linter/issues/392 was related a while ago.
I'm not entirely sure this is a desired addition, so please feel free to let me know if it's been ruled-out for whatever reason.
I'm also not entirely sure I've added this correctly, or really how to test it properly. I spent some time trying to build the docker containers locally, but never was succesful. Advise/guidance is appreciated!
Proposed Changes
Readiness Checklist
Author/Contributor
Reviewing Maintainer
breakingif this is a large fundamental changeautomation,bug,documentation,enhancement,infrastructure, orperformance