-
Notifications
You must be signed in to change notification settings - Fork 950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint the whole code base with JSCPD #2180
Conversation
@ferrarimarco I really like the approach but the main thing I can see is that if a user has a large codebase with multiple other languages, they could get longer times as it's going to check everything else... But the complexity to try to distinguish all that currently I don't think is worth the effort... This is likely the best, most simple fix to get that to work |
We could have a separate flag. It's easy to add, and could be flagged as non-breaking that way. Maybe it's worth adding? |
@ferrarimarco I like the idea, its more of a feature add, vs changing the way it works... |
@admiralAwkbar done, defined a new variable as requested. The thing is that we need to check our own duplications :) (or tune JSCPD until we're ready to deal with that). |
@admiralAwkbar all green! Merging the latest changes from main... |
* Lint the whole code base with JSCPD if VALIDATE_ALL_CODEBASE is true * Use VALIDATE_JSCPD_ALL_CODEBASE Co-authored-by: Lukas Gravley <admiralawkbar@github.com>
* Lint the whole code base with JSCPD if VALIDATE_ALL_CODEBASE is true * Use VALIDATE_JSCPD_ALL_CODEBASE Co-authored-by: Lukas Gravley <admiralawkbar@github.com>
Fixes #1619
Proposed Changes
This PR adds support to run JSCPD on the codebase as a whole if
VALIDATE_JSCPD_ALL_CODEBASE
is set totrue
.Readiness Checklist
Author/Contributor
Reviewing Maintainer
breaking
if this is a large fundamental changeautomation
,bug
,documentation
,enhancement
,infrastructure
, orperformance
Requisites