Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint the whole code base with JSCPD #2180

Merged
merged 6 commits into from
Dec 8, 2021
Merged

Lint the whole code base with JSCPD #2180

merged 6 commits into from
Dec 8, 2021

Conversation

ferrarimarco
Copy link
Collaborator

@ferrarimarco ferrarimarco commented Nov 26, 2021

Fixes #1619

Proposed Changes

This PR adds support to run JSCPD on the codebase as a whole if VALIDATE_JSCPD_ALL_CODEBASE is set to true.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

Requisites

@ferrarimarco ferrarimarco added the enhancement New feature or request label Nov 26, 2021
@ferrarimarco ferrarimarco self-assigned this Nov 26, 2021
@admiralAwkbar
Copy link
Collaborator

@ferrarimarco I really like the approach but the main thing I can see is that if a user has a large codebase with multiple other languages, they could get longer times as it's going to check everything else...

But the complexity to try to distinguish all that currently I don't think is worth the effort...

This is likely the best, most simple fix to get that to work

@ferrarimarco
Copy link
Collaborator Author

We could have a separate flag. It's easy to add, and could be flagged as non-breaking that way. Maybe it's worth adding?

@admiralAwkbar
Copy link
Collaborator

@ferrarimarco I like the idea, its more of a feature add, vs changing the way it works...

@ferrarimarco ferrarimarco changed the title Lint the whole code base with JSCPD if VALIDATE_ALL_CODEBASE is true Lint the whole code base with JSCPD Dec 7, 2021
@ferrarimarco
Copy link
Collaborator Author

@admiralAwkbar done, defined a new variable as requested. The thing is that we need to check our own duplications :) (or tune JSCPD until we're ready to deal with that).

@ferrarimarco
Copy link
Collaborator Author

@admiralAwkbar all green! Merging the latest changes from main...

@admiralAwkbar admiralAwkbar merged commit e4b08ec into main Dec 8, 2021
@admiralAwkbar admiralAwkbar deleted the jscpd-all-codebase branch December 8, 2021 20:28
sarahc23 pushed a commit to 23andMe/super-linter that referenced this pull request May 6, 2022
* Lint the whole code base with JSCPD if VALIDATE_ALL_CODEBASE is true

* Use VALIDATE_JSCPD_ALL_CODEBASE

Co-authored-by: Lukas Gravley <admiralawkbar@github.com>
sarahc23 pushed a commit to 23andMe/super-linter that referenced this pull request May 6, 2022
* Lint the whole code base with JSCPD if VALIDATE_ALL_CODEBASE is true

* Use VALIDATE_JSCPD_ALL_CODEBASE

Co-authored-by: Lukas Gravley <admiralawkbar@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feed jscpd All Files At Once
2 participants