Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install R directly and don't report npm-groovy-lint usage stats #2202

Merged
merged 14 commits into from
Dec 7, 2021

Conversation

ferrarimarco
Copy link
Collaborator

@ferrarimarco ferrarimarco commented Dec 3, 2021

Fixes #2199

Proposed Changes

  1. Don't depend on https://github.com/assignUser/lintr-lib to install R, and install it directly. This is necessary because otherwise R breaks if the dependencies in https://github.com/assignUser/lintr-lib differ from the ones we install when building our image.
  2. Don't report npm-groovy-lint usage stats because it needs a full certificate chain to be in place.

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@ferrarimarco ferrarimarco added bug Something isn't working automation related to helping the project operate more efficiently labels Dec 3, 2021
@ferrarimarco ferrarimarco marked this pull request as draft December 3, 2021 19:05
@ferrarimarco
Copy link
Collaborator Author

Ok, now R works, but Groovy doesn't :(

@ferrarimarco ferrarimarco marked this pull request as ready for review December 4, 2021 22:27
@ferrarimarco
Copy link
Collaborator Author

2021-12-04 21:51:39 [ERROR]   Found errors in [npm-groovy-lint] linter!
2021-12-04 21:51:39 [ERROR]   Error code: 1. Command output:
------
/tmp/lint/.automation/test/groovy/groovy_good_01.groovy


npm-groovy-lint results in 0 linted files:
┌─────────┬───────────┬─────────────┐
│ (index) │ Severity  │ Total found │
├─────────┼───────────┼─────────────┤
│    0    │  'Error'  │      0      │
│    1    │ 'Warning' │      0      │
│    2    │  'Info'   │      0      │
└─────────┴───────────┴─────────────┘
Unexpected error: unable to get local issuer certificate
Error: unable to get local issuer certificate
    at TLSSocket.onConnectSecure (node:_tls_wrap:1530:34)
    at TLSSocket.emit (node:events:390:28)
    at TLSSocket._finishInit (node:_tls_wrap:944:8)
    at TLSWrap.ssl.onhandshakedone (node:_tls_wrap:725:12)
------

@ferrarimarco
Copy link
Collaborator Author

@admiralAwkbar R works now, but npm-groovy-lint doesn't :(

One issue solved, one other pops out.

@ferrarimarco
Copy link
Collaborator Author

@admiralAwkbar can you have a look as well? Maybe you know how to fix the error above

@admiralAwkbar
Copy link
Collaborator

@ferrarimarco the root of the issue:)

--insight                    npm-groovy-lint collects anonymous usage statistics using package https://www.npmjs.com/package/insight. If you do not want to share them, use
                               --no-insight option

SInce we don't have a full CA chain, it's mad...

@ferrarimarco
Copy link
Collaborator Author

/facepalm

@ferrarimarco ferrarimarco changed the title Install R directly Install R directly and don't report npm-groovy-lint usage stats Dec 7, 2021
@admiralAwkbar admiralAwkbar merged commit f90bf96 into main Dec 7, 2021
@admiralAwkbar admiralAwkbar deleted the fix-r branch December 7, 2021 18:10
sarahc23 pushed a commit to 23andMe/super-linter that referenced this pull request May 6, 2022
…r-linter#2202)

* Install R directly

* Don't install zip

* Copy etc/R

* Move back to /home/r-library

* Copy directory contents

* Copy files

* mkdir

* recursive copy

* copy -r

* Revert R etc

* Don't create etc dir

* Disable ClassNameSameAsFilename rule

* insight kills

Co-authored-by: Admiral Awkbar <admiralawkbar@github.com>
sarahc23 pushed a commit to 23andMe/super-linter that referenced this pull request May 6, 2022
…r-linter#2202)

* Install R directly

* Don't install zip

* Copy etc/R

* Move back to /home/r-library

* Copy directory contents

* Copy files

* mkdir

* recursive copy

* copy -r

* Revert R etc

* Don't create etc dir

* Disable ClassNameSameAsFilename rule

* insight kills

Co-authored-by: Admiral Awkbar <admiralawkbar@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation related to helping the project operate more efficiently bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

R cannot find a required library
2 participants