fix default value name for JAVA_FILE_NAME #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default vale name for JAVA_FILE_NAME is `sun_checks.yml` and not `sun-checks.yml` as mentioned in the README. P.S. Idk if there is any PR template for this repo.
rohanjaswal2507
requested review from
admiralAwkbar,
ferrarimarco,
GaboFDC,
Hanse00,
jwiebalk,
nemchik and
zkoppert
as code owners
|
the PR looks good. @admiralAwkbar do you know why it's not kicking in the rest of the workflows? |
ferrarimarco
approved these changes
Dec 5, 2021
|
Ok I checked. The other workflows don't trigger on PRs. Will open another issue to discuss. |
sarahc23
pushed a commit
to 23andMe/super-linter
that referenced
this pull request
May 6, 2022
The default vale name for JAVA_FILE_NAME is `sun_checks.yml` and not `sun-checks.yml` as mentioned in the README.
sarahc23
pushed a commit
to 23andMe/super-linter
that referenced
this pull request
May 6, 2022
The default vale name for JAVA_FILE_NAME is `sun_checks.yml` and not `sun-checks.yml` as mentioned in the README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default vale name for JAVA_FILE_NAME is
sun_checks.ymland notsun-checks.ymlas mentioned in the README.Proposed Changes
Readiness Checklist
Author/Contributor
Reviewing Maintainer
breakingif this is a large fundamental changeautomation,bug,documentation,enhancement,infrastructure, orperformance