Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add protolint config #2252

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Add protolint config #2252

merged 1 commit into from
Jan 3, 2022

Conversation

NotFounds
Copy link
Contributor

@NotFounds NotFounds commented Dec 21, 2021 •
edited by ferrarimarco
Loading

Proposed Changes

We often write the protolint configuration in a file .protolint.yaml to run linter locally.
cf. https://github.com/yoheimuta/protolint#configuring

However, in CI, the config file name is .protolintrc.yml, which is annoying to manage twice.

Adding the ability for the user to supply .protolintrc.yml instead of ours only

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

@ferrarimarco ferrarimarco added the enhancement New feature or request label Dec 21, 2021
@ferrarimarco
Copy link
Collaborator

Thanks for this PR @NotFounds

@ferrarimarco ferrarimarco added the documentation Improvements or additions to documentation label Dec 21, 2021
admiralAwkbar
admiralAwkbar approved these changes Jan 3, 2022
View reviewed changes
Copy link
Collaborator

@admiralAwkbar admiralAwkbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!
Sorry, this wasn't already in here!

@admiralAwkbar admiralAwkbar merged commit 2d82178 into super-linter:main Jan 3, 2022
sarahc23 pushed a commit to 23andMe/super-linter that referenced this pull request May 6, 2022
@NotFounds @sarahc23
add protolint config (super-linter#2252)
1762ebb
sarahc23 pushed a commit to 23andMe/super-linter that referenced this pull request May 6, 2022
@NotFounds @sarahc23
add protolint config (super-linter#2252)
2fbb116
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@admiralAwkbar admiralAwkbar admiralAwkbar approved these changes

@ferrarimarco ferrarimarco Awaiting requested review from ferrarimarco ferrarimarco is a code owner

@GaboFDC GaboFDC Awaiting requested review from GaboFDC

@Hanse00 Hanse00 Awaiting requested review from Hanse00 Hanse00 is a code owner

@jwiebalk jwiebalk Awaiting requested review from jwiebalk

@nemchik nemchik Awaiting requested review from nemchik

@zkoppert zkoppert Awaiting requested review from zkoppert zkoppert is a code owner

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NotFounds @ferrarimarco @admiralAwkbar