Revert "Add find-unicode-control2 (#2286)" #2299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 46b9e49.
lindluni
requested review from
admiralAwkbar,
ferrarimarco,
GaboFDC,
Hanse00,
nemchik and
zkoppert
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unicode script introduced in #2286 is an unmaintained script released by RedHat as a stopgap for their clients. This is unfortunate in that it is already broken, the latest version of python rearranges a library which causes the script to break.
While I completely understand the need for this, as an open source project whose scale is already difficult to maintain all it's cross-dependencies, adding an unmaintained script to the arsenal of linters isn't the best approach. If some organization chooses to fork the script and agrees to maintain, that would be reasonable to introduce it, but RedHats disclaimer that it the script is "presented as is, with no support or updates" is a tough pill to swallow.
The security community has been working to add BiDi linters to the language specific linters. These should be adopted where possible, I see Rust, C++, and Python ones already available with a quick search.